Help me improve my code?

Pikachu11 · August 4, 2016, 5:57pm

Well my title seems vague. But, I realized that I have an MoparScape account for +4 years, and decided to be active on the community. Finally decided to learn Java, during my life crisis in trying to do something with my life.

Issue #1: Panel arrangement
I created a program, and there are minor issues with how the FlowLayout() is trying to do it’s job but is not working out too well. Not sure if is something to do with how I setup my panels, or I am just being stupid.

Here is the image, as you can see the JLabel() Setting and Frequency is like together… Not sure if I should add each of them on a different panels. All the Panels are being handled within different methods.

Issue #2: Creating a dynamic JLabel()?
Well, As you can see I have a custom range which user can enter through JTextField(). However my algorithm only does up to 1-10. How would I achieve, in a way that it does not take too much space? I was thinking to set a limit where user can only input from 1-100. So when the program runs, it will only “show” that specific range?

And here is the current algorithm, which uses for enhanced loops which can be found at my source code, GraphicalInterface.java

[code=java] private void frequencyMethod() {
//Issue #1: labelFrequency is being floated to the left with labelSetting
mainPanel.add(labelFrequency);
int counter = 0;

	for (JLabel label : frequencyLabel) {
		frequencyLabel[counter] = new JLabel(Integer.toString(counter+1));
		frequencyStatsLabel[counter] = new JLabel("0%");
		panelFrequency.add(frequencyLabel[counter]);
		panelFrequency.add(frequencyStatsLabel[counter]);
		counter += 1;
	}
}[/code]

Anyways here is the source code:

gist.github.com

https://gist.github.com/hahajoker181/b14898bfe89c52970fb08efc7ef6e802

Generator.java

package akiraff.project.statistics;

import java.io.BufferedWriter;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Paths;
import java.util.ArrayList;
import java.util.Collections;
import java.util.concurrent.ThreadLocalRandom;

This file has been truncated. show original

GraphicalInterface.java

package akiraff.project.statistics;

import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.IOException;

import javax.swing.BoxLayout;
import javax.swing.JButton;
import javax.swing.JFrame;

This file has been truncated. show original

NumberGenerator.java

package akiraff.project.statistics;

public class NumberGenerator {
	
	public static void main(String[] args){
		GraphicalInterface gui = new GraphicalInterface();
	}
}

Roar337 · August 4, 2016, 6:30pm

Hiya, Pika =D

Issue #1:
I have a couple thoughts on this first if you are designing a Gui why not use a Gui designer? :S
It would help you greatly you could simply use a null layout and drag and drop and see in real time exactly where your components go and what its going to look like
also generated code and less mistakes will save you loads of time…

Issue #2:
You can only do 10 because you only have space allocated for 10 frequency lables however you could convert back to a normal for loop and do something a bit like this:

for(int i=0; i < getCount(); i++) {

}

private int getCount() {
     return (recursionCount > 0 ? recursionCount : frequencyLabel.length);
}